-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPEDGE-811: chore: dependency bumps for k8s 1.29 #546
OCPEDGE-811: chore: dependency bumps for k8s 1.29 #546
Conversation
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@jakobmoellerdev: This pull request references OCPEDGE-811 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jakobmoellerdev: This pull request references OCPEDGE-811 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/test all |
/test unit-test |
/test lvm-operator-e2e-aws-sno |
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@jakobmoellerdev: This pull request references OCPEDGE-811 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
Depends on openshift/release#47808 for go toolchain directive support in go.mod
Adjusts one test case that is affected by a breaking change in controller runtime in the latest release as it was assuming set TypeInfo which was now nilled out: kubernetes-sigs/controller-runtime#2633
In a real scenario, the Event will always be filled correctly